forms-bootstrap icon indicating copy to clipboard operation
forms-bootstrap copied to clipboard
verified publisher icon contributte

Fixes contributte/forms-bootstrap#100

Open vagovszky opened this issue 1 year ago • 3 comments

Fixes issue #100 - UploadInput field adds an extra unnecessary label to the HTML

vagovszky avatar Sep 24 '24 08:09 vagovszky

Hm, I'm not sure I want this... This is how it looks now image

This is how form looks after your edit: image

Can U attach screenshots what's really bothering you? This is a BC that will change a lot of forms and I can't just publish this...

dakorpar avatar Sep 30 '24 12:09 dakorpar

Hello dakorpar, I understand your concerns - you are responsible for the library and its compatibility. Note: I saw the same issue in v4 and v5. If you reject this change I will have to live with it. But it is really weird, that upload input label (html dom) is there twice. See following screenshots:

  1. Without my change - note the big blank spece between rows.

image

Html: image

  1. With my change

image

Html: image

Note: Isn't it possible that you removed extra row of code in your example by mistake?

image

vagovszky avatar Oct 10 '24 16:10 vagovszky

so maybe you need to do this only for inline edits? I'm not really a fan of doing changes that will change how things works in minor version changes... If we are going to merge this then I'd like that you add this as option which can be turned on. That way I can merge it, like this it will affect look & feel of existing projects and that's kinda no

dakorpar avatar Oct 24 '24 09:10 dakorpar