volplugin icon indicating copy to clipboard operation
volplugin copied to clipboard

Multiple policies with the same name

Open yuva29 opened this issue 9 years ago • 5 comments

When a policy with same name is uploaded twice, the user should be informed about the existing policy otherwise it leaves an impression that the new policy is in use which is not the case!

[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy1.json 
[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy2.json 

yuva29 avatar Oct 26 '16 17:10 yuva29

Seems good, maybe output the previous and existing policy and confirm? Offer a –y option to skip.

-Erik

From: Yuva Shankar <[email protected]mailto:[email protected]> Reply-To: contiv/volplugin <[email protected]mailto:[email protected]> Date: Wednesday, October 26, 2016 at 10:55 AM To: contiv/volplugin <[email protected]mailto:[email protected]> Subject: [contiv/volplugin] Multiple policies with the same name (#469)

When a policy with same name is uploaded twice, the user should be informed about the existing policy otherwise it leaves an impression that the new policy is in use which is not the case!

[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy1.json [vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy2.json

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/contiv/volplugin/issues/469, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ61Qdsik6qJ4yVRKc0MgbakIdz8R_ks5q35QigaJpZM4KheZX.

erikh avatar Oct 26 '16 19:10 erikh

So when someone uploads a new policy with the same name, it will affect all the existing volumes under that policy. I suppose we should not allow this operation itself. WDYT?

yuva29 avatar Oct 26 '16 23:10 yuva29

no, it will only affect the new volumes.

look at hte runtime upload option for how to affect volumes at runtime.

erikh avatar Oct 26 '16 23:10 erikh

That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.

yuva29 avatar Oct 27 '16 00:10 yuva29

This is what the policy archive is for; it can trace back these changes.

From: Yuva Shankar <[email protected]mailto:[email protected]> Reply-To: contiv/volplugin <[email protected]mailto:[email protected]> Date: Wednesday, October 26, 2016 at 5:21 PM To: contiv/volplugin <[email protected]mailto:[email protected]> Cc: Erik Hollensbe <[email protected]mailto:[email protected]>, Comment <[email protected]mailto:[email protected]> Subject: Re: [contiv/volplugin] Multiple policies with the same name (#469)

That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/contiv/volplugin/issues/469#issuecomment-256513834, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ6_GbHzxdP4QkzOr3yGCdR9_RwsaDks5q3-6AgaJpZM4KheZX.

erikh avatar Oct 27 '16 15:10 erikh