contenta_react icon indicating copy to clipboard operation
contenta_react copied to clipboard

Consider using superagent instead of axios for better JSON API support

Open spleshka opened this issue 8 years ago • 3 comments

I've noticed that devs at Lullabot use axios library for API calls to the backend. However, what we've found during the development for our clients, there is a great library which has awesome support for JSON API standard:

The last mentioned library provides really great DX for data processing which comes from D8 JSON API module:

  • Much less nested response structure
  • All attached data is being wrapped in magic fields which make them accessible as it was added straight to data (for example, you don't have to search for image data in the attachment, you can get image url as it was a usual node title)
  • Many more

spleshka avatar Jun 28 '17 13:06 spleshka

Interesting, for https://github.com/contentacms/contenta_vue_nuxt we used a combination of waterwheel + jsonapi-parse + axios. Maybe this could have been reduced to Waterwheel + SuperAgent-jsonapify ?

yann-yinn avatar Nov 18 '17 11:11 yann-yinn

We can use the normal fetch API instead of either Axios or SuperAgent, with a polyfill for node https://www.npmjs.com/package/isomorphic-fetch

justafish avatar Nov 19 '17 14:11 justafish

@justafish I am trying to develop this repo using the isomorphic-fetch method you recommend. I have today seen that spelshka (Evgeniy) has built a fully-fledged react demo app in a separate repo. But I want to continue development of your demo app. That is: based on create-react-app and isomorphic-fetch. I and my colleague are hoping to develop our React skills along the way. Please advise me on the best way i can contribute to this repo.

andrewfandrew avatar Nov 25 '18 20:11 andrewfandrew