conmon icon indicating copy to clipboard operation
conmon copied to clipboard

Require golang 1.22

Open jnovy opened this issue 9 months ago • 5 comments

jnovy avatar May 05 '25 14:05 jnovy

@jnovy you need to run go mod tidy after bumping go version in go.mod.

kolyshkin avatar May 07 '25 00:05 kolyshkin

Also, go 1.22 is no longer supported since go 1.24 is out (i.e. since February 2025).

kolyshkin avatar May 07 '25 00:05 kolyshkin

Thanks @kolyshkin - silly me forgetting this.

For golang-1.24 we have a bit of a chicken and egg problem - it still hasn't landed to major current distros. E.g we have still go-1.23.6 in CentOS/RHEL.

jnovy avatar May 07 '25 10:05 jnovy

@jnovy Still working on this? At least use go mod tidy

rhatdan avatar Jun 01 '25 10:06 rhatdan

Go mod tidy was already done, maybe it makes sense to bump it even more to golang 1.23 now.

jnovy avatar Jun 02 '25 13:06 jnovy

Go mod tidy was already done, maybe it makes sense to bump it even more to golang 1.23 now.

Yes please

kolyshkin avatar Jul 15 '25 00:07 kolyshkin

@jnovy please

kolyshkin avatar Jul 16 '25 06:07 kolyshkin

@kolyshkin Maybe we should make this part of your https://github.com/containers/conmon/pull/569 ?

jnovy avatar Jul 16 '25 07:07 jnovy

@kolyshkin PTAL - golang requirement is now updated to 1.24

jnovy avatar Aug 07 '25 10:08 jnovy

Currently supported Go versions are 1.23 and 1.24. This will change soon (this month) when Go 1.25 is released.

But for now, I guess, we need to support both Go 1.23 and 1.24.

kolyshkin avatar Aug 07 '25 18:08 kolyshkin

Ephemeral COPR build failed. @containers/packit-build please check.

@kolyshkin Thanks, I updated the printf statements, I think it's fair to update to 1.25 soon but merge this one first.

jnovy avatar Aug 08 '25 10:08 jnovy

@kolyshkin Thanks, I updated the printf statements, I think it's fair to update to 1.25 soon but merge this one first.

That's not what I meant. Let me try again.

The go <version> directive in go.mod specifies the minimally required go version. This means that anything older is not supported.

So we should not use 1.24 in there (as we still want 1.23 to be supported), and we should not switch it to 1.25 as soon as it's out (we still want 1.24 to be supported).

In general, we should be conservative here, meaning at the very least support all officially supported Go versions (those are 1.23 and 1.24 now). Meaning, today I would put go 1.23 to go.mod, not go 1.24.

kolyshkin avatar Aug 08 '25 21:08 kolyshkin

Ok, merging with requiring at least go 1.23 to continue with your PR.

jnovy avatar Aug 11 '25 06:08 jnovy