bubblewrap icon indicating copy to clipboard operation
bubblewrap copied to clipboard

tests: use stat -c instead of --format for compatibility

Open sertonix opened this issue 1 year ago • 2 comments

eg. busybox stat only has -c and not --format

sertonix avatar Apr 19 '24 13:04 sertonix

Ok, done

sertonix avatar Apr 19 '24 16:04 sertonix

@alexlarsson, @cgwalters: Please confirm whether you are intending to enforce the rule that Signed-off-by must be from (something that looks like) a real name, and not from an obvious pseudonym?

This PR and #618 are both blocked by having a decision on that. I would personally be fine with a pseudonymous Signed-off-by, especially for small contributions - but I didn't write the rule, so I don't feel that I can be the one to change it.

smcv avatar Apr 19 '24 16:04 smcv

@alexlarsson, @cgwalters: Please confirm whether you are intending to enforce the rule that Signed-off-by must be from (something that looks like) a real name, and not from an obvious pseudonym?

This PR and #618 are both blocked by having a decision on that.

Right, enough is enough: I've waited too long for a decision on whether this and several other simple fixes can be landed, and it's not like we can tell whether any given contribution is Signed-off-by someone's legal name or a plausible pseudonym anyway, so I'm going to say the answer is "yes" and start merging pseudonymous contributions.

@alexlarsson, @cgwalters, if this is a problem, please revert the relevant changes (and then get equivalent fixes some other way).

smcv avatar Sep 30 '24 18:09 smcv

so I'm going to say the answer is "yes" and start merging pseudonymous contributions

(Except not right now, because unrelatedly the Github Actions configuration has regressed, so if anyone has objections to this, you have until the Actions are fixed to raise your objection.)

smcv avatar Sep 30 '24 18:09 smcv

It looks like the most canonical docs for this are https://github.com/cncf/foundation/blob/main/dco-guidelines.md

I believe the signoff line here qualifies.

cgwalters avatar Sep 30 '24 22:09 cgwalters