ttrpc-rust icon indicating copy to clipboard operation
ttrpc-rust copied to clipboard

fix timing issue of streaming

Open abel-von opened this issue 1 year ago • 3 comments

The stream request and data is handle asynchronously, if the data is handled when stream is not created yet, the data will be discarded and an error occur.

we should wait until the stream is created and then the subsequent message can be handled.

abel-von avatar Mar 14 '24 03:03 abel-von

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 25.22%. Comparing base (693f4c5) to head (431bfb8). Report is 1 commits behind head on master.

Files Patch % Lines
src/asynchronous/server.rs 0.00% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   24.33%   25.22%   +0.89%     
==========================================
  Files          16       16              
  Lines        2655     2704      +49     
==========================================
+ Hits          646      682      +36     
- Misses       2009     2022      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 14 '24 03:03 codecov[bot]

looks like ci is failing with https://github.com/containerd/ttrpc-rust/issues/219

jsturtevant avatar Mar 21 '24 17:03 jsturtevant