project icon indicating copy to clipboard operation
project copied to clipboard

[Proposal] Templates for Pull Requests

Open manugupt1 opened this issue 3 years ago • 2 comments

Nerdctl contributors were recently talking about having pull request templates / good commit messages. One thing that was proposed was Github PR templates

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-an[…]requests/creating-a-pull-request-template-for-your-repository

The PR template can ask the following questions:

  • What is the change?
  • Why is the change important (can be fixes something)?
  • Any gotchas to be aware of?

cc @containerd/nerdctl-committers & @containerd/nerdctl-maintainers

manugupt1 avatar Jan 06 '23 01:01 manugupt1

Is the suggestion here to have a common pull request template for each containerd subproject?

samuelkarp avatar Jan 06 '23 07:01 samuelkarp

I think having a common template would make most sense; but I am not sure of the entire context of the how the project operates to make a call. I opened this to get some feedback from members.

manugupt1 avatar Jan 07 '23 22:01 manugupt1