nri icon indicating copy to clipboard operation
nri copied to clipboard

[API Enhance Request] Rename UpdateContainersRequest type name

Open zhaodiaoer opened this issue 11 months ago • 0 comments

Currently, there are two types with very similar names defined in api.proto: UpdateContainersRequest and UpdateContainerRequest. Although the functional positioning of these two types is completely different, their names only differ by an's', which makes the relevant code very confusing. Similarly, there are also UpdateContainersResponse and UpdateContainerResponse has same problem.

Please consider modifying the type names of UpdateContainersRequest and UpdateContainersResponse in version 1.0 to make them more distinguishable. For example, change them to UnsolicitedUpdateContainers{Request, Response} or something that is shorter.

zhaodiaoer avatar Mar 03 '25 09:03 zhaodiaoer