nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

Add Windows hostprocess support

Open jsturtevant opened this issue 4 years ago • 4 comments

Add the correct specs fields to https://github.com/containerd/nerdctl/blob/f316402913c4239a2388b7467bcffc9735dd8327/cmd/nerdctl/run_windows.go#L42

Something like:

hpc, err := cmd.Flags().GetBool("host-process")
if err != nil {
  return nil, err
}
if hpc {
  //TODO append the right hpc opts
}

See https://github.com/containerd/containerd/pull/5131 for details on how to set the right spec fields.

jsturtevant avatar Nov 16 '21 16:11 jsturtevant

Planning to look at this next week

dcantah avatar Jan 06 '22 21:01 dcantah

@AkihiroSuda What's the story for how certain things should be handled if they require a specific Containerd version? hostprocess (Windows' version of a privileged container) will be a feature for Containerd 1.6 and currently only works in the beta releases until a full release.

dcantah avatar Jan 06 '22 21:01 dcantah

What's the story for how certain things should be handled if they require a specific Containerd version?

Just mentioning that in docs/windows.md would be fine

AkihiroSuda avatar Jan 07 '22 05:01 AkihiroSuda

Ok awesome, thanks!

dcantah avatar Jan 07 '22 06:01 dcantah