fifo

fifo copied to clipboard

Add ReaderFrom/WriterTo for Linux (splice)

8

On Linux, we can use `splice` to optimize copies to happen in kernel when copying to other files. Since this is already a pipe, this should always work when copying...

cpuguy83

I'm seeing different behaviours on MacOS and Linux, when closing a reader. When running `make test` with https://github.com/containerd/fifo/pull/42 applied, the `TestFifoCloseWhileReadingAndWriting` fails on MacOS but passes on Linux. On MacOS,...

sameo

Or else, the caller will never know when to cancel the passed-in context.

Random-Liu

Failed to compile under windwos

1

vendor\github.com\tonistiigi\fifo\fifo.go:42: undefined: unix.Mkfifo vendor\github.com\tonistiigi\fifo\handle_nolinux.go:18: undefined: syscall.Stat_t vendor\github.com\tonistiigi\fifo\handle_nolinux.go:19: undefined: syscall.Stat vendor\github.com\tonistiigi\fifo\handle_nolinux.go:33: undefined: syscall.Stat_t vendor\github.com\tonistiigi\fifo\handle_nolinux.go:34: undefined: syscall.Stat

etsangsplk

Hello @samuelkarp, When I used fifo, I found a potential bug, I'm not sure, maybe we can discuss to avoid a goleak blocking position: https://github.com/containerd/fifo/blob/3e17f98903a83f1a6c7368ea4694e6861161d6bd/fifo.go#L124-L133 if users use the OpenFilo()...

user12031

Resize fifo to 1024K

6

The container which writes logs synchronously would be blocked in the following scenarios: 1. Container writes logs synchronously to stdout or stderr . 2. Upgrade containerd and speed a lot...

kkkkun

add LockOSThread to kill thread

2

@thaJeztah try to fix this issue https://github.com/golang/go/issues/14592

ningmingxiao