continuity

continuity copied to clipboard

TestUsage broken on ZFS

2

When I run `TestUsage` in the `fs` package with a temp dir on a ZFS mount, it fails like this: ``` $ TMPDIR=/testpool/tmp go test ./fs -v -run TestUsage ===...

samuelkarp

Should the default pathDriver walk though volume mount points on Windows?

8

While implementing WCOW for the containerd snapshotter (https://github.com/containerd/containerd/pull/4419), I bounced off https://github.com/golang/go/issues/26033 in calls to `fstest.CheckDirectoryEqualWithApplier` and had to [work around it](https://github.com/containerd/containerd/pull/4419/commits/100624ba59f76fd771a81dd38b088b1ed66d44b8) rather nastily. The summary of the issue is...

TBBle

Change name of "context" to "environment"

3

This will make it much easier to understand code the involves `context.Context` and the thing that manipulates the local filesystem.

stevvooe

[WIP|RFC] fs: add DiffDirChanges function to get changeset fast

2

Since AUFS/OverlayFS can persist changeset in diff directory, DiffDirChanges function can retrieve layer changeset from diff directory without walking the whole rootfs directory. Signed-off-by: Wei Fu

fuweid

For efficiency, `fs.CopyFile` should use `clonefile(2)` on macOS when `VOL_CAP_INT_CLONE` is available. man: https://github.com/apple/darwin-xnu/blob/xnu-7195.101.1/bsd/man/man2/clonefile.2

AkihiroSuda

See https://github.com/moby/moby/issues/41866 Basically, need to add `EINVAL` on this line: https://github.com/containerd/continuity/blob/180525291bb77dea7062ac4281fcd38e2a3d76c5/fs/copy_linux.go#L90 Also worth considering if any error should cause the fallback. I haven't isolated the kernel version/zfs version that causes...

codyps

https://github.com/containerd/continuity/blob/180525291bb77dea7062ac4281fcd38e2a3d76c5/fs/copy.go#L161-L176 The current implementation of `CopyFile` does not support copying metadata. `CopyFile` should optionally copy the metadata as in `CopyDir`

AkihiroSuda

Should os.ModeCharDevice be taken into account?

2

Relates to https://github.com/moby/moby/pull/38758 / https://github.com/moby/moby/pull/38404#issuecomment-465151750 / https://github.com/golang/go/commit/a2a3dd00c934fa15ad880ee5fe1f64308cbc73a7 Due to a change in Go 1.12, some file modes are no longer being returned as `os. ModeDevice`, but as `os.ModeCharDevice`. This caused...

thaJeztah

s390x: copy_file_range error in container

6

On `s390x` the copy package fails if run inside a container because it fails to detect the existence of `copy_file_range` properly. If ran on host https://github.com/containerd/continuity/blob/7f53d412b9eb1cbf744c2063185d703a0ee34700/fs/copy_linux.go#L74 fails with ENOSYS and...

tonistiigi

Currently the copy functionality added in the `fs` package is just used for copying a directory and is called `CopyDir`. We should rename this to `Copy` and expand its abilities...

dmcgowan