base icon indicating copy to clipboard operation
base copied to clipboard

feat: add Wally

Open guidojw opened this issue 1 year ago • 8 comments

Adds support for the Wally package manager. https://github.com/renovatebot/renovate/discussions/25339

Installing Wally on Ubuntu focal will cause libssl errors. I tried installing the correct libssl here in a prepare class but that was too much of a hassle where it needs jammy apt sources in order to even be able to find the version, but for its dependencies too, so in the end I made it throw an error instead.

guidojw avatar Feb 24 '24 20:02 guidojw

Because of the focal limitation, this PR is blocked by https://github.com/containerbase/base/pull/1991.

guidojw avatar Feb 24 '24 21:02 guidojw

@guidojw do you mean that wally will only work on Ubuntu 22.04?

rarkins avatar Feb 25 '24 06:02 rarkins

@guidojw do you mean that wally will only work on Ubuntu 22.04?

Yes, Wally only works with libssl3 and focal comes with 1.1. I tried installing 3 on focal but this meant pointing apt repositories for libssl specifically to the jammy ones, which worked but then it started erroring about libc6 also not being the right version. I could point libc6 to jammy repositories too but read online that this is not a good idea because lots of os components might depend on it.

guidojw avatar Feb 25 '24 14:02 guidojw

Right now we're still defaulting to Ubuntu 20 for our builds I think

rarkins avatar Feb 25 '24 15:02 rarkins

Yeah, https://github.com/containerbase/base/pull/1991 should be the only thing blocking this right? I'll convert to draft until that is merged

guidojw avatar Feb 25 '24 15:02 guidojw

I'll prepare our own prebuilds soon

viceice avatar Aug 01 '24 08:08 viceice

I'll resolve the comments and split those changes into another PR soon then 👍🏿

guidojw avatar Aug 06 '24 11:08 guidojw

https://github.com/containerbase/wally-prebuild/releases/tag/0.3.2 💪 aarch64 binaries are coming in a couple of minutes

viceice avatar Aug 12 '24 14:08 viceice

@guidojw any chance to continue soon?

viceice avatar Dec 06 '24 08:12 viceice

@viceice resolved comments and updated code to latest project standards 👍🏿

guidojw avatar Dec 07 '24 23:12 guidojw

The prebuilds repository README says focal is supported, but the code here will error on that due to the libssl error, is that a problem? https://github.com/containerbase/wally-prebuild?tab=readme-ov-file#local-development

guidojw avatar Dec 07 '24 23:12 guidojw

image use the re-request review button to request a new review 😉

viceice avatar Dec 11 '24 07:12 viceice

you need a noble workaround: https://github.com/containerbase/base/blob/9f9475abf07266bf23ba726b54f88ffd803c39e3/src/cli/tools/php/index.ts#L93-L96

viceice avatar Dec 12 '24 20:12 viceice