ksql icon indicating copy to clipboard operation
ksql copied to clipboard

fix: default port URL composition issue

Open dinegri opened this issue 4 years ago • 3 comments

Description

I was struggling to connect in ksql using ksql-cli. I configured ksql behind a reverse proxy using a location, after some time I realized that providing the url to ksql cli:

https://ksqlab.confluent.io/lab1 it was changing to https://ksqlab.confluent.io/lab1:443 or http://ksqlab.confluent.io/lab1 it was changing to http://ksqlab.confluent.io/lab1:80

Testing done

Added two unit test for the scenario described above

Reviewer checklist

  • [x] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • [x] Ensure relevant issues are linked (description should include text like "Fixes #")

dinegri avatar Jul 31 '21 13:07 dinegri

@confluentinc It looks like @dinegri just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jul 31 '21 13:07 ghost

Hi @AlanConfluent, any chances of this PR be reviewed?

We start using ksqlDB in the company I work and we face this issue once we are trying to configure ksqlDB REST Interface of many application behind a reverse proxy using the same url but different context

Thank you in advance

dinegri avatar Aug 25 '21 19:08 dinegri

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Nov 15 '23 20:11 cla-assistant[bot]

Closing stale PR. I'm sorry that we didn't get this done. Please resubmit as a new PR if you still want to get it in.

vvcephei avatar Feb 26 '24 16:02 vvcephei