semver-resource icon indicating copy to clipboard operation
semver-resource copied to clipboard

skip_ssl_verification source config not working for git driver

Open ym294 opened this issue 2 years ago • 0 comments

Describe the bug

When trying to use "skip ssl verification" option for git driver in semver Resource type for concourse a GO error occurs:

fatal: bad boolean config value "'false'" for http.sslVerify

I believe this is caused by the syntax on line 181 in /driver/git.go of this repo:

181: gitSkipSSLVerification := exec.Command("git", "config", "--global", "http.sslVerify", "'false'")

where the false string is in single quotes surrounded by double quotes.

Reproduction steps

  1. Initialise a semver resource in Concourse YAML config with "skip_ssl_verification: true"
  2. Run in pipeline ...

Expected behavior

The resource should check and initialise without the need for SSL verification when using the git driver in the semver resource.

Additional context

No response

ym294 avatar Jan 05 '24 10:01 ym294