github-release-resource icon indicating copy to clipboard operation
github-release-resource copied to clipboard

Non-idempotent releases with same tag should fail

Open xinzweb opened this issue 9 years ago • 3 comments

We have the following snippet in our pipeline

  plan:
  - get: gpos_src
    passed:
    - gpos_centos5_release
  - get: bin_gpos_centos5_release
    passed:
    - gpos_centos5_release
    trigger: true
  - task: gpos_publish_tag
    file: gpos_src/concourse/publish_tag.yml
  - put: gpos_github_release
    params:
      name: gpos_github_release_stage/tag.txt
      tag: gpos_github_release_stage/tag.txt
      commitish: gpos_github_release_stage/commit.txt
      globs:
        - gpos_github_release_stage/bin_gpos_centos5_release.tar.gz

Currently if the job is triggered twice with:

  1. different commits in gpos_src
  2. different tar balls from bin_gpos_centos5_release
  3. same content in the tag.txt file

Then we observe the following behavior:

  1. Both put will succeed
  2. The value of the tag stays with the commit from the first put
  3. The files attached are from the second put

Is it reasonable that we should expect the second put to flat out fail?

xinzweb avatar May 19 '16 20:05 xinzweb

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • [ ] #119948447 Non-idempotent releases with same tag should fail

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

concourse-bot avatar May 19 '16 20:05 concourse-bot

+1

geofffranks avatar Sep 27 '16 20:09 geofffranks

Let's take the approach of failing if the tag with a commit that is different that the put.

jtarchie avatar Aug 28 '17 20:08 jtarchie