github-release-resource icon indicating copy to clipboard operation
github-release-resource copied to clipboard

`get` fails: grpc string contains invalid UTF-8 character

Open braunsonm opened this issue 1 year ago • 1 comments

Describe the bug

I'm trying to use this resource to get a Github Release which I think contains a UTF-8 character (right-arrow)

The error I get during the get is:

set label: grpc: error while marshaling: string field contains invalid UTF-8: unknown

The configuration of the github release module is:

  - name: knative-operator
    type: github-release
    icon: github
    check_every: 24h
    source:
      owner: knative
      repository: operator
      access_token: ((github_access_token))

...

- get: knative-operator
  trigger: true
  params:
    globs:
      - knative-operator-*.tgz

Reproduction steps

  1. Create a pipeline as described above
  2. Run it
  3. See the error in the get step

Expected behavior

The get operation should complete successfully. Or a way to disable the body label.

Additional context

I think this might be coming from the Github Release body containing an arrow. The release in question is here: https://github.com/knative/operator/releases/tag/knative-v1.13.0

braunsonm avatar Jan 31 '24 18:01 braunsonm

I think the error is actually coming from here: https://github.com/concourse/concourse/blob/05fce1356860277e3c851f2c5d2551bec34731cc/worker/runtime/container.go#L240-L243

Making a fix in concourse/concourse is probably better.

taylorsilva avatar Mar 13 '25 17:03 taylorsilva

I'm hitting this too, with:

- name: otel-java-instrumentation-github-release
  type: github-release
  icon: github
  source:
    owner: open-telemetry
    repository: opentelemetry-java-instrumentation
    tag_filter: "^v?(2\\.16\\.0)$"

The release notes for v2.16.0 contain a :toolbox: character, which Concourse barfs on.

scarytom avatar May 21 '25 15:05 scarytom

I have raised Issue 9205 against concourse/concourse for this.

scarytom avatar May 21 '25 15:05 scarytom

Closing this in favour of concourse/concourse#9205

taylorsilva avatar May 22 '25 17:05 taylorsilva