concourse
feat(gw-api): Support HTTPRoute
Why do we need this PR?
Adds support for HTTPRoute resources usually attached with gateway-apis
Changes proposed in this pull request
- add helm unittest to run helm unit tests on specific helm templates
- modify readme to add web.route.*
- update values
- update .gitignore/.helmignore
Contributor Checklist
- [X] Variables are documented in the
README.md - [dev]
Reviewer Checklist
This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.
- [ ] Code reviewed
- [ ] Topgun tests run
- [ ] Back-port if needed
- [ ] Is the correct branch targeted? (
masterordev)
FYI, i don't know if going forward you plan on using the unit test framework from helm, but if so, might be beneficial to include it as part of the ci process.
I think it was on our list long ago, just never got prioritized. Just scanned your PR and saw you added some! Looks easy enough to add to our CI process. I'll add it as a TODO for when I review this PR.
If you want I can rework it to include it. (The ci portion not write the tests for all the cases) :)
Lol ain't that wonderful.
If it's ok with you, I'll check this over tomorrow. They should be working. Otherwise, we can do like you suggest, merge and create a separate PR for the tests
No rush, just planning to release a minor version of the chart and would love to get this in since it's been sitting here for a while.
i actually put the wrong types for hostnames and parentRefs it was a real error, nice unittests 👍
EDIT: branch is still targeting dev, I don't know if that's intentional
Yeah target branch should've been dev, that's decided when the PR is made. Could change it now, but I'll be merging dev into master when I make the next chart release, so not a big deal in this case.