serverless-plugin-nested-stacks icon indicating copy to clipboard operation
serverless-plugin-nested-stacks copied to clipboard
verified publisher icon concon121

Tests?

Open AdrieanKhisbe opened this issue 7 years ago • 5 comments

The package.json mention some tests? Notably using jasmine.

Are they unversionned tests, or this is just an artefact of scaffolding the project?

Setting up a CI could be interesting. I can do it if you want @concon121

AdrieanKhisbe avatar Oct 10 '18 10:10 AdrieanKhisbe

As you suspected, that is just a result of me copying a pasting from another package.json 😨

It would definitely be worth adding some sensible unit tests to this project given people have started using it!

concon121 avatar Oct 30 '18 14:10 concon121

I can help you on that if you want, and set up CI with travis, and lint with eslint. What do you think about this?

AdrieanKhisbe avatar Oct 30 '18 18:10 AdrieanKhisbe

Yeah if you have the time feel free 😄 any contributions to make things better are always welcome!

concon121 avatar Oct 31 '18 13:10 concon121

I set up the CI and the coverage. This will help to write more tests

AdrieanKhisbe avatar Nov 08 '18 09:11 AdrieanKhisbe

Awesome work, much appreciated!

concon121 avatar Nov 08 '18 15:11 concon121