examples icon indicating copy to clipboard operation
examples copied to clipboard

Fixed 'if' syntax error in bat.

Open zhangyiant opened this issue 4 years ago • 4 comments

zhangyiant avatar May 06 '21 07:05 zhangyiant

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 06 '21 07:05 CLAassistant

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

memsharded avatar May 06 '21 08:05 memsharded

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

It's really broken. The "else" in build.bat cannot work if it's on a separate line, but the script will continue to run. So it has almost no impact. Anyway, it's a bug in the script, so fix it incidentally.

zhangyiant avatar May 06 '21 12:05 zhangyiant

@memsharded, @zhangyiant I have just fixed the CI error for the MacOs node, looks like the CI it's working now again.

czoido avatar May 06 '21 13:05 czoido