ui icon indicating copy to clipboard operation
ui copied to clipboard

Add focus within ts type definition

Open balazsmatepetro opened this issue 5 years ago • 5 comments

This PR adds the missing type definition files for FocusWithin component.

balazsmatepetro avatar Jun 04 '20 10:06 balazsmatepetro

🦋 Changeset is good to go

Latest commit: 161bbe738c6ce9c11768ad8875320e39e17102df

We got this.

This PR includes changesets to release 1 package
Name Type
@component-driven/react-focus-within Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 04 '20 10:06 changeset-bot[bot]

@balazsmatepetro did you figure out the bundling problem?

okonet avatar Jun 05 '20 10:06 okonet

@balazsmatepetro did you figure out the bundling problem?

I had a look at on it, as I've seen the type definitions are included in the bundle, but it might worth converting the whole component into TypeScript.

balazsmatepetro avatar Jun 23 '20 15:06 balazsmatepetro

I think it's worth converting it to TS. Want to give it a try?

okonet avatar Jun 24 '20 11:06 okonet

Sure!

balazsmatepetro avatar Jun 24 '20 12:06 balazsmatepetro