Saleem Abdulrasool

Results 516 comments of Saleem Abdulrasool

@swift-ci please test Windows platform

Yes, that is the reason: `-rdynamic` is a driver level flag and allows the linker driver (clang/gcc, cl unfortunately does not serve as a linker driver) to translate the flag...

Sorry, missed that part. I need to look up the autoconf macro, but the idea is that this doesn't require a linker check, this is something that we can directly...

We just ran this locally and the results we are getting are: ``` Failed Tests (17): Swift(windows-aarch64) :: ClangImporter/availability_returns_twice-msvc-aarch64.swift Swift(windows-aarch64) :: ClangImporter/unicode.swift Swift(windows-aarch64) :: IRGen/pic.swift Swift(windows-aarch64) :: IRGen/windows-linking.swift Swift(windows-aarch64) ::...

This seems reasonable. https://github.com/swiftlang/swift/pull/86558 should fix a number of those. Can you sync past that change and re-test?

There was an experimental patch at https://github.com/llvm/llvm-project/pull/147292 that we might need to pull in here.

I'd guess its a file path normalisation issue - the separator and escaping might be causing issues.

I think that the approach for this is to specify `-resource-dir` to the resource directory that we ship with the compiler. That will ensure that we get the right headers....