Surface from rhino
- Fixed
Surfacepluggablefrom_planeso that it's possible to create a planar surface in Rhino. - Added
from_nativeinnative_surfaceinSurfaceandRhinoSurfaceto align better with theBrepsystem. - Added deprecation warning on
RhinoSurface.from_rhino. - Replaced
Boxargument withu_domainandv_domaininRhinoSurface.from_plane. - Changed
new_surfacepluggin to create aRhinoSurfaceobject instead ofSurface. - Default constructors in
SurfaceandNurbsSurfaceare protected. Caller must use one of the alternative constructors.
https://miro.com/app/board/uXjVK2eWeOk=/
What type of change is this?
- [x] Bug fix in a backwards-compatible manner.
- [x] New feature in a backwards-compatible manner.
- [x] Breaking change: bug fix or new feature that involve incompatible API changes.
- [ ] Other (e.g. doc update, configuration, etc)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
- [x] I added a line to the
CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed). - [x] I ran all tests on my computer and it's all green (i.e.
invoke test). - [x] I ran lint on my computer and there are no errors (i.e.
invoke lint). - [ ] I added new functions/classes and made them available on a second-level import, e.g.
compas.datastructures.Mesh. - [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have added necessary documentation (if appropriate)
Codecov Report
Attention: Patch coverage is 34.48276% with 38 lines in your changes missing coverage. Please review.
Please upload report for BASE (
main@b7111f2). Learn more about missing BASE report.
| Files | Patch % | Lines |
|---|---|---|
| src/compas/geometry/surfaces/nurbs.py | 18.18% | 27 Missing :warning: |
| src/compas/geometry/surfaces/surface.py | 56.00% | 11 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1350 +/- ##
=======================================
Coverage ? 59.90%
=======================================
Files ? 206
Lines ? 22162
Branches ? 0
=======================================
Hits ? 13277
Misses ? 8885
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
replaced by https://github.com/compas-dev/compas/pull/1375