commons-app
Fixes Issue #5619: Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload
Description (required)
Fixes #5619
What changes did you make and why? Added label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload" whenever user switches off the selectorSwitch.
Here is a useful link to find unassigned bugs:
https://github.com/commons-app/apps-android-commons/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Adebated+label%3Abug+-label%3A%22low+priority%22
:-)
Any idea why the text is not displayed here? Thanks! 🙂
1000044741.mp4
Will check on it sir !
@nicolas-raoul
SIr earlier I thought the images.notempty will do the work. But now it seems the images are of total device and the filetered images is of the the particular folder. I tried using the
notForUploadStatusDao.getNotForUploadFromImageSHA1(image.id.toString()) == null
But it didnt work. If you could point me to where from can i get the status of images which are marked as not for upload or maked as upload it would be helpful.
Thanks.
Sorry for the delay! I don't think that using the DAO is needed. I believe that checking whether the message should be displayed or not can be done on the UI side.
Sorry for the delay! I don't think that using the DAO is needed. I believe that checking whether the message should be displayed or not can be done on the UI side.
okay sir will try
I believe this was finished in https://github.com/commons-app/apps-android-commons/pull/6095 🙂