apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Refactor: nearby models

Open ben-mathu opened this issue 3 years ago • 1 comments

Part of an ongoing code refactoring to move all models to a common models package.

Fixes #4782

Moved nearby models to data.models package.

Tested debug on Pixel 4 (Emulator) with API level 30.

ben-mathu avatar Feb 28 '22 11:02 ben-mathu

Codecov Report

Merging #4865 (6ea3911) into master (87b9648) will decrease coverage by 0.20%. The diff coverage is n/a.

:exclamation: Current head 6ea3911 differs from pull request most recent head 3b4d85e. Consider uploading reports for the commit 3b4d85e to get more accurate results

@@             Coverage Diff              @@
##             master    #4865      +/-   ##
============================================
- Coverage     50.66%   50.45%   -0.21%     
+ Complexity     2231     2189      -42     
============================================
  Files           338      335       -3     
  Lines         15531    15375     -156     
  Branches       1358     1343      -15     
============================================
- Hits           7869     7758     -111     
+ Misses         7079     7037      -42     
+ Partials        583      580       -3     
Impacted Files Coverage Δ
...okmarks/locations/BookmarkLocationsController.java 100.00% <ø> (ø)
...mons/bookmarks/locations/BookmarkLocationsDao.java 81.66% <ø> (ø)
...bookmarks/locations/BookmarkLocationsFragment.java 81.48% <ø> (ø)
...ategory/CategoryEditSearchRecyclerViewAdapter.java 28.57% <ø> (ø)
.../commons/contributions/ContributionController.java 10.86% <ø> (ø)
...w/commons/contributions/ContributionsFragment.java 31.59% <ø> (-0.33%) :arrow_down:
...r/free/nrw/commons/contributions/MainActivity.java 76.00% <ø> (ø)
...fr/free/nrw/commons/media/MediaDetailFragment.java 34.10% <ø> (ø)
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java 16.20% <ø> (ø)
.../fr/free/nrw/commons/nearby/CheckBoxTriStates.java 59.57% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87b9648...3b4d85e. Read the comment docs.

codecov[bot] avatar Mar 02 '22 18:03 codecov[bot]