apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Ambiguities on nearby map marker

Open neslihanturan opened this issue 6 years ago • 2 comments

Summary: Recently I discovered a weird issue. Sometimes there are two different wikidata items with same labels (yes this is possible for wikidata, the unique id is entity id). Firstly they looks non useful on the map, see two different Ataşehir label, one is for the district, the other is for municipality building.

  • My proposed solution to solve this UX issue is, adding first 10 chars of descriptions next to label.

Then I recognized this issue also causes a bug. As you can see from the map, both of them are green, but only one of them has the image attribute.

  • This will require another PR to check pic attribute from wikidata id, instead of wikidata label.

neslihanturan avatar Mar 17 '20 10:03 neslihanturan

} else if (!place.pic.trim().isEmpty()) { vectorDrawable = VectorDrawableCompat.create( // Means place has picture getContext().getResources(), R.drawable.ic_custom_map_marker_green, getContext().getTheme() );

@neslihanturan can you tell me what info does pic field contain? its a string but how do we update its value.

318anushka avatar Apr 02 '20 15:04 318anushka

It contains Property:P18 of related wikidata item for this place. https://www.wikidata.org/wiki/Property:P18

neslihanturan avatar Apr 02 '20 18:04 neslihanturan