cwltool icon indicating copy to clipboard operation
cwltool copied to clipboard

Fix spurious validation error with scatter+conditionals

Open tetron opened this issue 4 years ago • 3 comments

Typing related to conditionals should be part of the computed output signature of the step, not added in by the checker.

refs #1639

tetron avatar Mar 07 '22 21:03 tetron

Codecov Report

Merging #1640 (21da544) into main (0f70992) will decrease coverage by 0.02%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
- Coverage   66.82%   66.79%   -0.03%     
==========================================
  Files          93       93              
  Lines       16578    16578              
  Branches     4404     4404              
==========================================
- Hits        11078    11074       -4     
- Misses       4361     4364       +3     
- Partials     1139     1140       +1     
Impacted Files Coverage Δ
cwltool/checker.py 85.02% <ø> (-1.37%) :arrow_down:
cwltool/workflow.py 85.32% <77.77%> (-0.33%) :arrow_down:
cwltool/cwltool/checker.py 86.78% <0.00%> (-0.45%) :arrow_down:
cwltool/cwltool/workflow.py 75.67% <0.00%> (+0.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f70992...21da544. Read the comment docs.

codecov[bot] avatar Mar 07 '22 21:03 codecov[bot]

This pull request introduces 1 alert when merging c4442a81f599105fa7f4b4a6e35625c790996b57 into 0f70992a7407c49d0655ee2ca898c2019a56908d - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Mar 07 '22 21:03 lgtm-com[bot]

This pull request introduces 1 alert when merging 21da544d8794d612ff7d4fb2383343be281bd025 into 0f70992a7407c49d0655ee2ca898c2019a56908d - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Mar 08 '22 12:03 lgtm-com[bot]