commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

ci(github-actions): add "3.13-dev" to Python tests (#1145)

Open jakob-keller opened this issue 1 year ago • 1 comments

Description

Checklist

  • [ ] Add test cases to all the changes you introduce
  • [ ] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [ ] Test the changes on the local machine manually
  • [ ] Update the documentation for the changes

Expected behavior

GitHub Actions will run tests for Python 3.13 (dev).

Steps to Test This Pull Request

Additional context

closes #1145

jakob-keller avatar Jun 26 '24 19:06 jakob-keller

Looks like there are currently incompatibilities with cffi under Python 3.13: https://github.com/python-cffi/cffi/issues/77 We will need to await their next release which is imminent.

jakob-keller avatar Jun 26 '24 20:06 jakob-keller

looks like they've got it resolved. but rebasing doesn't seem to work still

Lee-W avatar Jul 26 '24 02:07 Lee-W

looks like they've got it resolved. but rebasing doesn't seem to work still

Apparently it was fixed, but the release is still pending.

jakob-keller avatar Jul 26 '24 07:07 jakob-keller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.56%. Comparing base (120d514) to head (82c0459). Report is 395 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   97.33%   97.56%   +0.22%     
==========================================
  Files          42       55      +13     
  Lines        2104     2502     +398     
==========================================
+ Hits         2048     2441     +393     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.56% <ø> (+0.22%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 06 '24 20:08 codecov[bot]

cffi==1.17.0 has been released, which helps a lot.

Now it turns out that Python 3.13 modifies the behaviour of argparse --help: https://github.com/python/cpython/pull/103372. I have updated relevant tests accordingly. Please let me know, if we need to keep the tests for Python 3.12 and earlier.

There is also a single failing test caused by the removal of pipes in Python 3.13: https://github.com/pre-commit/mirrors-prettier is no longer maintained, but used in test_bump_pre_commit_changelog. I have marked that test as skip for the time being. IMO, the test should be modified to avoid mirrors-prettier, independent of Python 3.13 support.

jakob-keller avatar Aug 08 '24 21:08 jakob-keller

I'll keep it open for a few days. cc @woile @noirbizarre

Lee-W avatar Aug 09 '24 03:08 Lee-W