commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

fix: set shell to False if running subprocess on Windows

Open my1e5 opened this issue 1 year ago • 2 comments

Description

When running a subprocess through run in cmd.py, if the OS is Windows set shell=False.

Closes https://github.com/commitizen-tools/commitizen/issues/1118 and https://github.com/commitizen-tools/commitizen/issues/1117

Checklist

  • [ ] Add test cases to all the changes you introduce
  • [x] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [x] Test the changes on the local machine manually
  • [ ] Update the documentation for the changes

Expected behavior

Running rye run cz bump on a Windows machine in a rye-managed project now works.

my1e5 avatar May 20 '24 09:05 my1e5

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.58%. Comparing base (120d514) to head (d0fdb2f). Report is 439 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   97.33%   97.58%   +0.24%     
==========================================
  Files          42       55      +13     
  Lines        2104     2486     +382     
==========================================
+ Hits         2048     2426     +378     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.58% <ø> (+0.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 09:05 codecov[bot]

Looks like CI is failing on windows. We might need to take a deeper look

Lee-W avatar May 20 '24 14:05 Lee-W