sphere-node-sdk icon indicating copy to clipboard operation
sphere-node-sdk copied to clipboard
verified publisher icon commercetools

Ensure that product sync/differ create only one update action for setAttributeInAllVariants

Open butenkor opened this issue 10 years ago • 6 comments

If product has 5 variants with attribute brand and brand has been changed in all variants from A to B then product-sync will generate 5 update actions of type setAttributeInAllVariants. It should generate only one update action per product and attribute flaged as sameForAll.

butenkor avatar Aug 18 '15 09:08 butenkor

Sounds good :+1:

Can you make a PR?

emmenko avatar Aug 18 '15 13:08 emmenko

:+1: would be nice to get a PR :+1:

pgbytes avatar Aug 18 '15 14:08 pgbytes

@butenkor please provide a test case first - as this feature should be working already! https://github.com/sphereio/sphere-node-sdk/blob/master/src/spec/sync/utils/product.spec.coffee#L870

hajoeichler avatar Aug 19 '15 21:08 hajoeichler

@hajoeichler Yes test seems to be correct. @panshul007 Can you still reproduce this issue?

butenkor avatar Aug 21 '15 07:08 butenkor

Is this still a problem?

emmenko avatar Nov 11 '15 20:11 emmenko

@panshul007 This question is for you. Next time create issues yourself ;)

butenkor avatar Nov 12 '15 07:11 butenkor