Version 3.4.5 not backward compatible with 3.4.4 - Added optional chaining operator

Open giuseppeturelli opened this issue 1 year ago • 2 comments

Hi,

Just FYI we noticed that version 3.4.5 is not fully backward compatible with 3.4.4 as in our project we are still using ecmascript2015 which does not support optional chaining operator (holidays.js line 388, commit https://github.com/commenthol/date-holidays-parser/commit/4b11197787f9eb05f08fdf989bd3fbc48be4f025).

Nov 28 '24 11:11 giuseppeturelli

Same issue here, our builds suddenly broke. We are using date-holidays on 3.21.3, and due to the loose version locking in it's package.json it automatically started using 3.4.5 of this package.

If anyone stumbles on this issue whilst using date-holidays, you can apply a temp fix by adding "date-holidays-parser": "3.4.4" to your package.json

Dec 12 '24 10:12 JonathanVelkeneers

@giuseppeturelli Sorry for breaking your build. I did not thought about es2015 compatibility.

Dec 12 '24 20:12 commenthol