commaai
Show alert when user flag (bookmark) pressed
Description:
This PR implements showing an alert when the user flags a position on the route with the bookmark icon.
Reason for this feature:
There's currently very little feedback that occurs when the button is pressed. This makes it difficult to be sure that the button was pressed successfully.
Screenshot:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think we might not want to change the border color for this - that has to always show the openpilot engagement state.
I think we might not want to change the border color for this - that has to always show the openpilot engagement state.
That's fair, it was just one of the suggestions along with the feature request, and also I thought it would make more sense to match the timeline color that shows in connect.
It would definitely make it less complex to not do that.
would it be fine to include the yellow border around the bookmark button itself to make it more obvious?
would it be fine to include the yellow border around the bookmark button itself to make it more obvious?
You mean when the button is clicked or all the time? That's a good idea though.
I think we might not want to change the border color for this - that has to always show the openpilot engagement state.
I'd be okay with just the pop-up alert saying it's flagged, that stays for ~2 sec. I just suggested the yellow border to match connect but it's not needed.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.