HKG: official long control signal for CANFD

[devtekve]

Route with this signals present: e1107f9d04dfb1e2/000002ad--1bbf941882

This adds a lot of details on the reversed signals following the official DBC. This signal was formerly known as SCC_CONTROL

[!NOTE] Process replay successful on

• https://github.com/commaai/openpilot/pull/36051

[devtekve]

@sshane @adeebshihadeh this one is still in draft because I need to have some people test it given that some signals were misidentified, and that meant a few logic changes. So I must make sure the controls still work as expected. If you have an HKG vehicle that sues this signals it would help.

My car uses them, but it’s very hacky at the moment since I have to mess with an ECU interceptor to use them properly or suffer trying to silence the ECU.

[magicbear2025]

@devtekve

a5205fb7e46c605b/0000011d--f80fc8d17e

A brief attempt at kludging this in. got harness errors but thought maybe some clues there. I haven't yet looked at it.

Lmk if I need to share it with an email ... Or don't want a self annoited tester

[devtekve]

@devtekve

a5205fb7e46c605b/0000011d--f80fc8d17e

A brief attempt at kludging this in. got harness errors but thought maybe some clues there. I haven't yet looked at it.

Lmk if I need to share it with an email ... Or don't want a self annoited tester

Thanks I’ll have a look, make sure the route has all the logs uploaded and it’s either marked public or shared directly with me [email protected]

[devtekve]

@devtekve

a5205fb7e46c605b/0000011d--f80fc8d17e

A brief attempt at kludging this in. got harness errors but thought maybe some clues there. I haven't yet looked at it.

Lmk if I need to share it with an email ... Or don't want a self annoited tester

After reviewing, the issue was specific to being a fork bringing this PR but not updating all the references to SCC_CONTROL on the fork. This PR only updates whatever is present on stock OP. More details https://discord.com/channels/469524606043160576/1398666511639384205/1398672894510235729

[devtekve]

@sshane @jyoung8607 @adeebshihadeh can we help get this one moving? I have a few more dbc stuff I'd like to merge too. I've made a PR in OP to run the process replay with this branch to make sure nothing is broken https://github.com/commaai/openpilot/pull/36051

[github-actions[bot]]

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

[devtekve]

@sshane @adeebshihadeh nudge on this, I’m not fancying solving conflicts to have it sitting for months

[sshane]

We will get back to this soon, busy week with the release!