ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Update process is deleting the model folder if it is of type junction

Open gontz opened this issue 1 year ago • 5 comments

Your question

Situation: When I use the update_comfyui.bat or update_comfyui_and_python_dependencies.bat it always deletes the folder models if that folder is a junction folder (like a symlink for folders) As I like to keep all my models in folders outside the comfyui folder, can you do something about it? As in not to delete the folder during the update? Thank you

Logs

No response

Other

No response

gontz avatar Aug 16 '24 16:08 gontz

Use the https://github.com/comfyanonymous/ComfyUI/blob/master/extra_model_paths.yaml.example config file instead of symlinks.

comfyanonymous avatar Aug 16 '24 17:08 comfyanonymous

Yes, I do use the extra path file but there are always new models and models folders being constantly added therefore it is more efficient to have a folder outside comfyui and symlink it. And having multiple comfyui installations depending on the plugins used, it is more efficient a symlink folder than extra paths file

gontz avatar Aug 16 '24 17:08 gontz

Yes, I do use the extra path file but there are always new models and models folders being constantly added therefore it is more efficient to have a folder outside comfyui and symlink it. And having multiple comfyui installations depending on the plugins used, it is more efficient a symlink folder than extra paths file

It is not more efficient since it is the same thing. Just point to the parent folder where you put all your models and the subfolders will be loaded by the config accordingly.

oliverban avatar Aug 16 '24 18:08 oliverban

A lot of plugins are creating folders inside models folder and downloading files in it. When I reinstall Comfy (quite often) I would need to go check what new files/folders have been added in the meantime. Your solution (pointing to a models folder in the extra paths file) would work only if the new files would be downloaded in the new path (the one from extra paths file). Which is not the case.

gontz avatar Aug 16 '24 18:08 gontz

If you have git you can try: git stash pop in the ComfyUI directory after running the update. The updater pushes current changes into the stack it doesn't discard them.

comfyanonymous avatar Aug 16 '24 22:08 comfyanonymous

This issue is being marked stale because it has not had any activity for 30 days. Reply below within 7 days if your issue still isn't solved, and it will be left open. Otherwise, the issue will be closed automatically.

github-actions[bot] avatar Feb 23 '25 11:02 github-actions[bot]