ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Inconsistency between KSampler and SamplerCustom from discarding penultimate sigma

Open chaObserv opened this issue 1 year ago • 0 comments

Expected Behavior

With same setting, the result of KSampler and SamplerCustom should be the same. If not, it would need to show a hint to explain the difference at somewhere.

Actual Behavior

Currently, KSampler implements discarding penultimate sigma for specific samplers (dpm2, unipc) to try to make their result better. (code here) However, sigmas and sampler for SamplerCustom are created individually, which cannot handle penultimate sigma now. It leads to different result when using those sampler even with same setting.

Steps to Reproduce

Make a workflow including KSampler and SamplerCustom with same setting. Use dpm_2, dpm_2_ancestral, uni_pc or uni_pc_bh2 would find result different. Other samplers would be same.

The first image uses UniPC, and second one uses DPM++ 2M to show the difference. sampler_example sampler_example2 Workflow above: unipc_workflow.json

Debug Logs

No relevant log

Other

No response

chaObserv avatar Aug 15 '24 02:08 chaObserv