ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Improvements to the webUI History and Queue lists

Open Slickytail opened this issue 1 year ago • 2 comments

This PR updates UI code and CSS to achieve the following features for the prompt history and prompt queue lists.

  • Automatic scaling of the size of the list
  • Approximate preservation of the scroll position when the list is updated.

This second part fixes a longstanding annoying that myself and other users have noted where the scroll position is lost even when no new elements are added, as a result of the websocket refreshing the list in the background.

The preservation of scroll position is "approximate" because it does not properly add the offset from new or deleted entries after update. To really solve this problem, we'd have to reimplement a minimal version of the react dom-diffing algorithm, in order to preserve the individual dom elements themselves, and therefore the scroll anchors that the browser uses. I didn't do that, because it felt like a lot of added complexity for very little gain.

Slickytail avatar Jun 18 '24 15:06 Slickytail

Could you add some screenshots?

You might also want to look into this: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scroll_snap

DrJKL avatar Jun 27 '24 20:06 DrJKL

20240702_16h22m33s_grim Here's a screenshot of the expanded history list. It's just longer, and it scales until the sidebar fills 90vh.

Slickytail avatar Jul 02 '24 14:07 Slickytail

frontend is replaced by https://github.com/Comfy-Org/ComfyUI_frontend now

mcmonkey4eva avatar Sep 16 '24 03:09 mcmonkey4eva