ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Please add the node id to progress messages from the WebSockets implementation (also towards parallel execution)

Open vincenzoml opened this issue 2 years ago • 2 comments

In the websockets protocol, progress messages don't contain the node id, which has to be deducted by the previous "executing" message. If parallel execution was enabled, such protocol would not work anymore. So I suggest to add the node id also to the progress messages, so that programs using the WS protocol can be already "future-proofed" and be prepared for parallel execution.

[EDIT]: for similar reasons also an "execution finished" message for nodes would be required (unless 100% progress already means "finished", not sure about that)

vincenzoml avatar Jan 01 '24 11:01 vincenzoml

How about also adding the prompt id to the message? execution_start, execution_cached, executing and executed all have it, only progress doesn't. It can be useful for large cluster deployment environments (#2401).

Chaoses-Ib avatar Jan 01 '24 12:01 Chaoses-Ib

https://github.com/comfyanonymous/ComfyUI/commit/66831eb6e96cd974fb2d0fc4f299b23c6af16685

comfyanonymous avatar Jan 01 '24 19:01 comfyanonymous