colorfulappl
colorfulappl
NEWS added :)
> Also, could you please add tests for each case? Do you mean put the test cases into test_linic.py? To see if the OOB bug is fixed in commit https://github.com/python/cpython/pull/32092/commits/620396279cf94e09bd7cd6e925e6e80471130d6f...
> does that mean we don't have any actual standard library argument clinic uses of this str conversion via codec functionality yet? Yes, I have searched this in CPython source...
> You'll also need to modify `configure.ac`, `Makefile.pre.in`, and `Modules/Setup.stdlib` for the new module; you can `grep -i` for `_testcapi` in those files to see what needs to be done....
Sorry, I have been busy with other stuff these days so this PR is delayed. :( I am planning to finish this in this week. Here I made some changes...
I have added some test cases. Their "clinic input" are mostly copied from `Lib/test/clinic.test` and modified a bit. A few cases crash the interpreter unexpectedly. One is newly found, when...
@erlend-aasland Yes, I think it's ready for review though the test still crashes due to problems I mentioned above.
> First pass, you can check for refleaks with `./python -m test -R 3:3 test_foo` Thanks, I don't know pytest has such a feature before. Now the refleaks are fixed,...
> for each bug, file an issue (unless there is one already) and open a PR that fixes the bug and adds the functional test for that specific bug. I...
> Thank you so much! I've started a final review. At first sight, there are some minor PEP 7 and PEP 8 style nits (I can take care of those...