ormar icon indicating copy to clipboard operation
ormar copied to clipboard

Upgrade to SQLAlchemy 2.0

Open pmdevita opened this issue 2 years ago • 5 comments

SQLAlchemy 2.0 brings full typing support, performance improvements, and some support for declarative model creation and dataclasses which might prove interesting. It also solves this security issue here https://pyup.io/v/51668/f17/ It would be ideal to upgrade to it to keep receiving support.

Currently, we need to wait on databases to add support for it, but it seems they have a mostly working PR here https://github.com/encode/databases/pull/540

I'd be willing to put in a PR for it once that's ready.

pmdevita avatar Aug 24 '23 13:08 pmdevita

Just a heads up that the referenced pull request isn't moving forward very quickly and databases is short on maintainers — I'm the only one reviewing things right now and am not a user. If someone is interested in helping out on that pull request it may be appreciated!

zanieb avatar Aug 29 '23 19:08 zanieb

At long last the PR is merged! I'll start taking a look at integrating it on our end.

It might also be worth looking at https://github.com/tarsil/databasez which is a more actively maintained fork

pmdevita avatar Feb 21 '24 15:02 pmdevita

Please, we need an urgent update at least temporary support to SQLAlchemy==1.4.52

I know you're working on SQLAlchemy 2 and Pydantic 2, but we need ORMAR to support SQLAlchemy 1.4.52 at least.

I am receiving: ormar 0.12.2 depends on SQLAlchemy<1.4.42 and >=1.3.18

Many external dependencies are waiting for this version and I'm stuck

alexol91 avatar Mar 04 '24 15:03 alexol91

If you need something right now, you can install Ormar from my SQLAlchemy 2 branch https://github.com/pmdevita/ormar/tree/feature/sqlalchemy2 Everything should be working now and a number of dependencies are updated since the minimum version of Python has been increased to 3.8

pmdevita avatar Mar 04 '24 17:03 pmdevita

@alexol91 as programmers, we must learn the dark arts of using workarounds :). In case you didn't know about these:

  • Direct install: pip install git+https://github.com/pmdevita/ormar.git@feature/sqlalchemy2
  • requirements.txt: ormar @ git+https://github.com/pmdevita/ormar.git@feature/sqlalchemy2

jamesbraza avatar Mar 04 '24 17:03 jamesbraza