cognite-sdk-python icon indicating copy to clipboard operation
cognite-sdk-python copied to clipboard

Add `/models/statistics`

Open haakonvt opened this issue 1 year ago • 3 comments

Adds:

  • /models/statistics
  • /models/statistics/spaces
  • /models/statistics/spaces/byids

TODO:

  • [x] docstrings
  • [ ] tests
  • [x] add mocks
  • [ ] wait until this PR is merged: https://github.com/cognitedata/service-contracts/pull/2499

haakonvt avatar Jan 17 '25 01:01 haakonvt

Nice! Let's hold off on this until we publish the API though. I don't think we need to break anything, but I'm not 100% sure. Let's do a sync next week.

erlendvollset avatar Jan 17 '25 01:01 erlendvollset

How pandas viz in notebooks: image (could potentially be nicer? a lot is hidden in 'instances)

The other I'm pretty much happy with: image

haakonvt avatar Jan 17 '25 22:01 haakonvt

Codecov Report

Attention: Patch coverage is 98.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.76%. Comparing base (ca14da8) to head (90ca0c3). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...te/client/data_classes/data_modeling/statistics.py 96.96% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
+ Coverage   90.73%   90.76%   +0.02%     
==========================================
  Files         164      166       +2     
  Lines       24448    24547      +99     
==========================================
+ Hits        22184    22280      +96     
- Misses       2264     2267       +3     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/__init__.py 100.00% <100.00%> (ø)
cognite/client/_api/data_modeling/statistics.py 100.00% <100.00%> (ø)
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/testing.py 100.00% <100.00%> (ø)
...te/client/data_classes/data_modeling/statistics.py 96.96% <96.96%> (ø)

... and 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 17 '25 22:01 codecov[bot]

/gemini review

doctrino avatar Jul 17 '25 07:07 doctrino

/gemini review

doctrino avatar Jul 17 '25 08:07 doctrino

/gemini review

doctrino avatar Jul 17 '25 08:07 doctrino

/gemini review

doctrino avatar Jul 17 '25 08:07 doctrino

🦄

erlendvollset avatar Jul 23 '25 07:07 erlendvollset