cognite-sdk-python icon indicating copy to clipboard operation
cognite-sdk-python copied to clipboard

Instances: Include typing

Open doctrino opened this issue 1 year ago • 1 comments

Description

Introduce TypeInformation class to both match the spec, and also provide useful helper methods such that the data structure becomes easier to work with (compared to a triple nested dict)

image

Checklist:

  • [ ] Tests added/updated.
  • [ ] Documentation updated. Documentation is generated from docstrings - these must be updated according to your change. If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • [ ] Changelog updated in CHANGELOG.md.
  • [ ] Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

doctrino avatar Mar 24 '24 09:03 doctrino

Codecov Report

Attention: Patch coverage is 78.80795% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.32%. Comparing base (4ad52b8) to head (1c68808).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
+ Coverage   92.25%   92.32%   +0.06%     
==========================================
  Files         124      124              
  Lines       18539    18672     +133     
==========================================
+ Hits        17103    17238     +135     
+ Misses       1436     1434       -2     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/utils/_auxiliary.py 92.30% <100.00%> (+0.39%) :arrow_up:
cognite/client/data_classes/_base.py 92.56% <50.00%> (-0.21%) :arrow_down:
cognite/client/data_classes/data_modeling/query.py 91.98% <75.00%> (+0.07%) :arrow_up:
cognite/client/_api/data_modeling/instances.py 87.50% <90.62%> (-0.13%) :arrow_down:
...ite/client/data_classes/data_modeling/instances.py 89.36% <74.28%> (-3.57%) :arrow_down:

... and 5 files with indirect coverage changes

codecov[bot] avatar Mar 24 '24 13:03 codecov[bot]