Chi Wang comments

Results 114 comments of


                                            Chi Wang

`--incompatible_remote_build_event_upload_respect_no_cache` still uploads some `no-cache` outputs

Do you mean something similar to `--nobuild_event_json_file_path_conversion` but for the BES?

`--incompatible_remote_build_event_upload_respect_no_cache` still uploads some `no-cache` outputs

Okay, then it's essentially an uploader that: - only converted paths for blobs that are already uploaded. - also upload and convert paths for blobs that are in an allowlist....

`--incompatible_remote_build_event_upload_respect_no_cache` still uploads some `no-cache` outputs

Thanks for the clarifications! Now it's clear to me. Here is solution: we introduce a new flag `--experimental_remote_build_event_upload_outputs` whose values can be `all | minimal` and defaults to `all`. When...

`--incompatible_remote_build_event_upload_respect_no_cache` still uploads some `no-cache` outputs

SGTM. we can try to make this into `6.0` and if everything works well we can remove `experimental_` prefix and flip to `minimal` in the next major release.

BES: make uploader retry attempts configurable

The changes LGTM but I will let @michaeledgar to make the decision.

Stabilize unresolved symbolic links (--experimental_allow_unresolved_symlinks)

@lberki I am happy to review PRs :) cc @tjgq

Remote Downloader: Does not honor --remote_local_fallback

Now I look into this problem again, I agree with you and me in the past that we should have this configurable. I prefer to have the flag `--experimental_remote_downloader_http_fallback` to...

Retry on HTTP remote cache fetch failure

> Unfortunately, it doesn't seem to be possible to separate the two without much larger changes to the Bazel code-base as described in the PR description above: Sorry, I missed...

5.0rc1: Remote cache read failure "java.lang.RuntimeException: java.io.IOException: file.tmp (Not a directory)"

A lot of things have changed since 5. Please reopen if it's still happening.

Move BES upload check earlier, to prevent calling FindMissingBlobs

Ha, the reason we call `FindMissingBlobs` is, according to https://github.com/bazelbuild/bazel/pull/16299#issue-1377982847, to convert Paths for files that are already uploaded to the remote cache.