material-bread icon indicating copy to clipboard operation
material-bread copied to clipboard

Web documentation errors

Open aviemet opened this issue 5 years ago • 1 comments

There is a minor error on the documentation page for web setup instructions. The regex for matching loaders in the babel and webpack config examples is malformed. I was going to PR, but couldn't find where this was in source, so decided to just do an issue.

In the example for the TFF loader, it should change from /.(png|woff|woff2|eot|ttf|svg)$/ to /\.(png|woff|woff2|eot|ttf|svg)$/.

In the example for babel loader, it should change from /node_modules/(?!(material-bread|react-native-vector-icons)/).*/ to /node_modules\/(?!(material-bread|react-native-vector-icons)).*/.

It may also be useful to add a closing ] at the end of the rules section, unless it was left dangling on purpose.

I also just saw the same issue on the page for electron setup, so this may be the same for other parts of the docs too.

aviemet avatar Dec 13 '20 21:12 aviemet

made a PR: https://github.com/codypearce/material-bread/pull/460

nsldlr avatar Jun 04 '21 00:06 nsldlr