codu icon indicating copy to clipboard operation
codu copied to clipboard

fix: fixed problem with update bookmarks

Open Maczi01 opened this issue 1 year ago • 5 comments

✨ Codu Pull Request 💻

Codu Logo

Pull Request details

Fixed problems with update bookmarks - after click icon, article will be added to bookmarks + toast "Bookmark updated"

Any Breaking changes

Important. I am not sure it is most efficient solution.

In onSuccess I am invalidating query, with queryClient.invalidateQueries(); Imo problem is with invalidate all queries, not particular one. I tried with: queryClient.invalidateQueries([myBookmarks), but it doesn't work

Associated Screenshots

image

Summary by CodeRabbit

  • New Features
    • Introduced success notifications for bookmark updates in article previews.
    • Refactored bookmark mutation handling to improve user experience.

Maczi01 avatar Apr 02 '24 21:04 Maczi01

@Maczi01 is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 02 '24 21:04 vercel[bot]

Walkthrough

The update involves enhancing the ArticlePreview component with new functionalities to improve user experience. It now uses useQueryClient for managing query states and toast for displaying success messages, providing immediate feedback to users during bookmark updates.

Changes

File Summary
components/.../ArticlePreview.tsx Added imports for useQueryClient and toast. Refactored bookmark mutation handling with loading state and success toast. Added disabled attribute to bookmark button.

Poem

In a codebase, not so vast,
A rabbit hopped in, quite fast.
"Let's add some magic," it said with glee,
To make bookmarks as lively as can be.
🌟 With a toast that pops, and queries that dance,
Now every update gets its chance.
🐰 "With each change, we grow," whispers the rabbit,
"In this digital burrow, we weave our habit."


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 05bcb79b02530c4bd5f2afee7e04762505bdcf0a and 6b492b1444429efe36ab7a4fea2b51cb00a4aebd.
Files selected for processing (1)
  • components/ArticlePreview/ArticlePreview.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • components/ArticlePreview/ArticlePreview.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 02 '24 21:04 coderabbitai[bot]

Whooo, optimistic update can be perfect here. I am struggling with implement it, some query keys problem:

https://tanstack.com/query/v4/docs/framework/react/guides/optimistic-updates

Maybe we can change approach a littie bit and use disabled property on button? Something like: <button disabled={isLoading},

I can get isLoading from useMutation.

Maczi01 avatar Apr 05 '24 11:04 Maczi01

Whooo, optimistic update can be perfect here. I am struggling with implement it, some query keys problem:

https://tanstack.com/query/v4/docs/framework/react/guides/optimistic-updates

Maybe we can change approach a littie bit and use disabled property on button? Something like: <button disabled={isLoading},

I can get isLoading from useMutation.

Sorry I'm slow getting back to you. Yeah something like that might be good! I'll also take a look and see what options there is

NiallJoeMaher avatar Apr 08 '24 16:04 NiallJoeMaher

@NiallJoeMaher can you check it now? button will be disable during action, it prevent sending another request. Should be helpful :-) If not, we can talk about better solution

Maczi01 avatar Apr 19 '24 11:04 Maczi01