codu icon indicating copy to clipboard operation
codu copied to clipboard

Accessibility improvement opportunities

Open Shane-Donlon opened this issue 1 year ago • 4 comments

Context

Please provide any relevant information about your setup: Page Speed Insights results

Feedback:

  • Buttons do not have an accessible name  
  • Background and foreground colors do not have a sufficient contrast ratio.  

Screenshots

Google Lighthouse report error for poor contrast ratio in search bar Google Lighthouse report error for button does not have an accessible name

Shane-Donlon avatar Feb 20 '24 12:02 Shane-Donlon

Hello @Shane-Donlon, thanks for opening your first issue! your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

github-actions[bot] avatar Feb 20 '24 12:02 github-actions[bot]

I think I can take it, but it require design changes. Should I focus only on contrast, ore something else? Or wait for storybook (a11y tests can be done there)

Maczi01 avatar Feb 23 '24 15:02 Maczi01

@Maczi01 - I'm looking into this! I have some new designs. I also want to see how Storybook works with severside components. I know they recently started supporting this, and that's the way we are heading. The new designs will hopefully get rid of some of these issues.

Some of these things don't need to be fixed (like the CMD+K text) because it's just a placeholder and they can often fail here.

The button to scroll down definitely could use an accessible name, though, if you want to take that?

NiallJoeMaher avatar Feb 23 '24 15:02 NiallJoeMaher

Thanks for quick answer @NiallJoeMaher !

I heard they added support for RSC, but didn't try yet. No rush! If you need, I can try to help with it.

I can handle scroll issue, assign to me pls :-)

Maczi01 avatar Feb 23 '24 15:02 Maczi01