codu icon indicating copy to clipboard operation
codu copied to clipboard

Add light/dark mode for all pages.

Open NiallJoeMaher opened this issue 3 years ago • 16 comments

I would love to have a toggle feature like this Tailwind demo: https://syntax.tailwindui.com/

  • Should use the system settings by default
  • Use the dark: class to make it easier to control/update
  • We probably need a Theme wrapper for the application to make sure we can control it.
### Tasks
- [ ] https://github.com/codu-code/codu/issues/432
- [ ] https://github.com/codu-code/codu/issues/433
- [ ] https://github.com/codu-code/codu/issues/434
- [ ] https://github.com/codu-code/codu/issues/435
- [ ] https://github.com/codu-code/codu/issues/436
- [ ] https://github.com/codu-code/codu/issues/437

NiallJoeMaher avatar Oct 07 '22 10:10 NiallJoeMaher

@NiallJoeMaher Can you assign me this issue?

karnikagupta30 avatar Oct 07 '22 21:10 karnikagupta30

@tokyo3001 sure you can pick it up

pkspyder007 avatar Oct 08 '22 04:10 pkspyder007

Has there been some progress on this @tokyo3001?

jh3y avatar Oct 24 '22 13:10 jh3y

@jh3y @tokyo3001 is there any progress on this issue?

patrickhladun avatar Nov 05 '22 11:11 patrickhladun

If I get no updates today I will assign it to you @patrickhladun

NiallJoeMaher avatar Nov 05 '22 11:11 NiallJoeMaher

I can pick up this issue if it is important now and no one is doing it.

sonngdev avatar Feb 05 '23 13:02 sonngdev

There isn't anyone working on this yet. As you see it's been open since October. It's a nice to have as it doesn't impact functionality thankfully. If you want to tackle it I'd be happy to assign it you!

NiallJoeMaher avatar Feb 05 '23 13:02 NiallJoeMaher

I asked because this is the only issue with the Help wanted tag 😄 I don't mind taking it for now and joining more urgent issues in the future.

By the way, since this issue is heavily related to UI, do we have any UI design documentation/Figma file? If not, I can also come up with my version of dark/light UI then we can iterate from that.

sonngdev avatar Feb 05 '23 13:02 sonngdev

We had some light/dark mode pages earlier so I need to dig out some designs. Let's put this on hold until I have some designs for you or else we could end up in an endless back and forth 😹

NiallJoeMaher avatar Feb 05 '23 13:02 NiallJoeMaher

Would like to assist if not parked?

DarrachBarneveld avatar Sep 25 '23 17:09 DarrachBarneveld

Not parked! I'll link you the designs and some context etc. later or tomorrow. I'm about to jump on a flight. Because we can split this into multiple tasks.

NiallJoeMaher avatar Sep 25 '23 17:09 NiallJoeMaher

I found it!

https://www.figma.com/file/yKc7ind3lHUTpqkjTePy1N/codu.co?type=design&node-id=107%3A164&mode=design&t=DyfBx9s5qMItxEPZ-1

Light mode

I'm going to make a task list and we can start getting this done for Hacktoberfest! 🪂

NiallJoeMaher avatar Sep 27 '23 20:09 NiallJoeMaher

@DarrachBarneveld the task list is here now: https://github.com/codu-code/codu/issues/63#issue-1400957466

NiallJoeMaher avatar Sep 28 '23 06:09 NiallJoeMaher

@NiallJoeMaher Is there any task which will tackle light/dark mode for header and footer?

pateldivyesh1323 avatar Oct 02 '23 05:10 pateldivyesh1323

@pateldivyesh1323 great thinking! I think there is a few tasks you've made me think of.

  • The pop up menus (having the appropriate dark mode)
  • The footer #462 (leave a comment so I can assign it to you)
  • The sidebar features (screenshot below): Screenshot 2023-10-02 at 08 01 32

NiallJoeMaher avatar Oct 02 '23 07:10 NiallJoeMaher

@NiallJoeMaher

  • Support Us Page : Does not have dark mode
  • Getting Started, Your Posts, Profile Settings, Saved Posts : Does not have Light mode

pateldivyesh1323 avatar Oct 02 '23 07:10 pateldivyesh1323