codu icon indicating copy to clipboard operation
codu copied to clipboard

Debouncing liking a post in the hackiest way imaginable

Open JohnAllenTech opened this issue 1 year ago • 2 comments

✨ Codu Pull Request 💻

Fixes #914

Pull Request details

  • This is a disgusting way to do this and I wouldnt approve this PR
  • I have tried to debounce useMutation 6 different ways but I cant get it to work. This is 100% a skill issue in terms of FE work.
  • I hope someone sees this and is so disgusted they fix it correctly

Any Breaking changes

  • None

Associated Screenshots

https://github.com/user-attachments/assets/103b693a-9547-4e4a-b6ea-fcfa92139d10

I am spam clicking the like button. Not you need to throttle your connection locally as we need to imitate real life network calls. Calls locally resolve to fast to replicate this bug without the throttling.

JohnAllenTech avatar Oct 03 '24 03:10 JohnAllenTech

@JohnAllenTech is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 03 '24 03:10 vercel[bot]

Walkthrough

The changes in this pull request primarily focus on the like mutation within the postRouter of the API. The logic for decrementing the likes count has been refined to include a check for the successful deletion of a like before updating the count. This ensures that the likes count accurately reflects the current state of likes. Minor formatting adjustments were also made, including the removal of an unnecessary comment and restructuring of await statements for clarity.

Changes

File Change Summary
server/api/router/post.ts Modified like mutation logic to check for successful like deletion before decrementing likes count; minor formatting adjustments.

Assessment against linked issues

Objective Addressed Explanation
Liking a post continuously causes the like count to decrease (#914)
Disable the like button when liking/unliking a post (#914) The implementation does not address disabling the button.

🐰 In the meadow where likes do play,
A count so true, it won’t stray.
With checks in place, we hop with glee,
No more drops from a click spree!
So let’s like posts, one by one,
Accurate counts, oh what fun! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 03 '24 03:10 coderabbitai[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:41pm

vercel[bot] avatar Oct 03 '24 15:10 vercel[bot]