chore: added all selected columns to the groupBy function
β¨ Codu Pull Request π»
Fixes #1053
Pull Request details
Seems like a new thing in drizzle? Didnt try to revert versions just fixed it in place.
Any Breaking changes
- Potentially. I will need help to test this. Seems to work locally but need a second set of eyes before Id be confident to merge
Associated Screenshots
@JohnAllenTech is attempting to deploy a commit to the CodΓΊ Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
The changes in the pull request focus on enhancing the post management system within the postRouter. Key modifications include an updated groupBy clause in the published query, clarified return values for mutation procedures, consistent error handling for unauthorized access, improved transaction management for likes and bookmarks, and retained input validation schemas. These updates aim to provide a more robust and clear interaction model for users managing posts.
Changes
| Files | Change Summary |
|---|---|
| server/api/router/post.ts | - Updated groupBy clause in the published query to include additional fields. |
- Clarified return values for like and bookmark mutation procedures. |
|
| - Consistent error handling for unauthorized access across mutation procedures. | |
- Implemented transaction management in like and bookmark procedures. |
|
| - Retained input validation schemas for post management operations. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Ensure Post.slug is included in the GROUP BY clause (1053) |
β | |
| Articles page should work after seeding DB (1053) | β | The article page is still not functioning correctly. |
Possibly related PRs
- #1055: This PR modifies the
likemutation in thepostRouter, which is directly related to the changes made in the main PR regarding thelikeprocedure, particularly in terms of ensuring accurate handling of likes and improving transaction management.
Suggested labels
hacktoberfest-accepted, hacktoberfest
Suggested reviewers
- NiallJoeMaher
π In the garden, I hop and play,
With posts and likes, brightening the day.
Transactions smooth, errors kept at bay,
Oh, what joy in the code we lay!
Hopping through changes, come what may! πΌ
π Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL
π₯ Commits
Files that changed from the base of the PR and between 909133c71d4e21484a454b91055960fc89291313 and 389acab93bb3c7fe5afc557cb602bae2ae564ac7.
β Files ignored due to path filters (2)
-
package-lock.jsonis excluded by!**/package-lock.json,!**/*.json -
package.jsonis excluded by!**/*.json
π Files selected for processing (1)
- server/api/router/post.ts (1 hunks)
π§ Files skipped from review as they are similar to previous changes (1)
- server/api/router/post.ts
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Should we bump drizzle to the latest version to see what it breaks in this too (that's coming in a PR anyway π )
Should we bump drizzle to the latest version to see what it breaks in this too (that's coming in a PR anyway π )
Will do
@NiallJoeMaher bumped the dependency and everything is still working.
The latest updates on your projects. Learn more about Vercel for Git βοΈ
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| codu | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Oct 4, 2024 6:53am |