Sagar Sumit

Results 135 comments of Sagar Sumit

@KnightChess Addressed your feedback. Please take a look again.

Closing it in favor of #11146 as it's becoming hard to maintain two sepate PRs for insert and update.

@danny0405 Based on our discussion, I have removed the `HoodieMergeKey` API and created a subclass `HoodieMetadataMergedLogRecordScanner` which works with `ExternalSpillableMap` (instead of string keys). It is used only for `HoodieMetadataLogRecordReader`...

> @codope Have you made more progress on this fix? Not yet. We need to fix https://issues.apache.org/jira/browse/HUDI-7554 as well.

> Wouldn't it be better to fail create table if the partition columns are not at the end? This seems like it could lead to more confusion since you still...

@jonvex Can you please take a look at the last commit? I have updated the test to make it more clear what is getting fixed here. Essentially, the order of...

No, we have added validation and updated the docs.

Changes are not needed. Closing the PR.