basic-computer-games icon indicating copy to clipboard operation
basic-computer-games copied to clipboard

Super Star Trek rust: Cargo.lock is autogenerated; Cargo.toml name-change from 'rust' to 'trek'

Open logicalgraphs opened this issue 1 year ago • 4 comments

Cargo.lock should not be in the repository, as it is an auto- and locally-generated file using cargo build. Cargo.toml: the name property should be "trek" and not "rust".

logicalgraphs avatar Oct 19 '24 13:10 logicalgraphs

I tried to set-upstream branch "Issue918-Super_Star_Trek-rust" but I was told I don't have permission to create a remote branch. May I do this so I can create a pull request to fix this issue?

logicalgraphs avatar Oct 19 '24 13:10 logicalgraphs

What specifically are you asking for? I'm not expert at the GitHub UI, sadly

coding-horror avatar Oct 20 '24 01:10 coding-horror

I tried to set-upstream branch "Issue918-Super_Star_Trek-rust" but I was told I don't have permission to create a remote branch. May I do this so I can create a pull request to fix this issue?

just fork the repo and do your changes there, no reason to give you write access to the repo for such a simple change

AnthonyMichaelTDM avatar Jan 16 '25 02:01 AnthonyMichaelTDM

also also, in general there's no reason not to include the cargo.toml, quoting the rust book "When in doubt, check Cargo.lock into the version control system"

AnthonyMichaelTDM avatar Jan 16 '25 06:01 AnthonyMichaelTDM