basic-computer-games icon indicating copy to clipboard operation
basic-computer-games copied to clipboard

95 Weekday: Handles 1582 dates incorrectly

Open stevebosman opened this issue 4 years ago • 4 comments

The following line in the original code leads to an error if dates before 1582 are supplied (which is fine) 290 IF Y-1582 <0 THEN 1300

However it means the day of week calculation is performed on days in 1582, but before 15 October 1582 (the date the Gregorian calendar started).

I think the test should be changed to check that the supplied date is on or after 15 October 1582.

stevebosman avatar Jan 30 '22 11:01 stevebosman

I am currently looking at tidying up the Javascript implementation, but I am unsure whether I should unilaterally fix this on one implementation.

stevebosman avatar Jan 30 '22 11:01 stevebosman

sure, if it is a bug in the original code please put a note in the readme.md in the game folder!

coding-horror avatar Jan 30 '22 18:01 coding-horror

One of my todo items is to add a "translator / port notes" section to the readme.md of each game..

coding-horror avatar Mar 16 '22 04:03 coding-horror